Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM renderer does not show selection over regular background colors #4097

Closed
Tyriar opened this issue Sep 2, 2022 · 2 comments · Fixed by #4673
Closed

DOM renderer does not show selection over regular background colors #4097

Tyriar opened this issue Sep 2, 2022 · 2 comments · Fixed by #4673
Assignees
@Tyriar
Labels
area/renderer-dom type/bug Something is misbehaving
Milestone
5.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 2, 2022

The yellow text background should be blue here:

image
@Tyriar Tyriar added type/bug Something is misbehaving area/renderer-dom labels Sep 2, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 13, 2023
@Tyriar
DOM: Render selection color instead of cell bg
73a77cd 
Summary:

- Selection cell reuse has been added to the DOM renderer
- Selection bg override is now correctly set correctly
- Selection elements 'pretend' to be a decoration in order to render bg

Fixes xtermjs#4097
@Tyriar Tyriar mentioned this issue Aug 13, 2023
Merged
@Tyriar Tyriar self-assigned this Aug 13, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 13, 2023
@Tyriar Tyriar mentioned this issue Aug 14, 2023
Closed
@jerch
Copy link
Member

jerch commented Aug 14, 2023

Is this a regression? 🙈

@Tyriar
Copy link
Member Author

Tyriar commented Aug 14, 2023

I think it's always been like this, just a random bug I picked up that looked fairly easy

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 14, 2023
@Tyriar
Remove redundant condition
09fc798 
Part of xtermjs#4097
@Tyriar Tyriar mentioned this issue Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

DOM: Render selection color instead of cell bg Tyriar/xterm.js
2 participants
@Tyriar @jerch