Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import broken in jspm/systemjs #412

Closed
jgillich opened this issue Dec 15, 2016 · 3 comments
Closed

Import broken in jspm/systemjs #412

jgillich opened this issue Dec 15, 2016 · 3 comments
Assignees
Labels
type/bug Something is misbehaving

Comments

@jgillich
Copy link
Contributor

jgillich commented Dec 15, 2016

Not sure what is going on here, but I'm importing xterm.js via SystemJS and it fails horribly:

 GET XHR http://localhost:3000/app/jspm_packages/npm/xterm@2.2.1/dist/Generic.js [HTTP/1.1 404 Not Found 1ms]
// many more...

Somehow the browserify bundle doesn't work correctly and it instead calls require from SystemJS.
Not sure what's going here.

To reproduce:

  1. Install jspm
  2. Create a new directory and run jspm init
  3. jspm install npm:xterm
  4. In your index.js, do import Terminal from 'xterm'
  5. Load the page

It works when I use jspm instal github:sourcelair/xterm, in which case jspm doesn't even touch dist/xterm.js. I have absolutely zero idea why, and maybe I should be reporting this against jspm instead.

@parisk parisk self-assigned this Dec 15, 2016
@parisk parisk added the type/bug Something is misbehaving label Dec 15, 2016
@parisk
Copy link
Contributor

parisk commented Dec 15, 2016

This seems to be a duplicate of #397, can you please try this using the latest version on master?

@jgillich
Copy link
Contributor Author

Ah, that would explain why it works when installing from GitHub. Thanks! (a new npm release would be great though :)

@parisk
Copy link
Contributor

parisk commented Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants