Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IColorSet into a service #4184

Closed
Tyriar opened this issue Oct 8, 2022 · 0 comments · Fixed by #4188
Closed

Move IColorSet into a service #4184

Tyriar opened this issue Oct 8, 2022 · 0 comments · Fixed by #4188
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 8, 2022

We pass this around a lot, makes sense to live in a service so we can inject it
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Oct 8, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 8, 2022
@Tyriar
Create basic theme service
c4750ea 
Part of xtermjs#4184
@Tyriar Tyriar mentioned this issue Oct 8, 2022
Merged
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 8, 2022
@Tyriar Tyriar self-assigned this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Create theme service Tyriar/xterm.js
1 participant
@Tyriar