Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Italic emoji can get clipped #4229

Closed
Tyriar opened this issue Oct 25, 2022 · 0 comments · Fixed by #4237
Closed

Italic emoji can get clipped #4229

Tyriar opened this issue Oct 25, 2022 · 0 comments · Fixed by #4237
Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2022

In demo:

image
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 28, 2022
@Tyriar
Fix bbox right scan start offset
8b545a3 
This causes particularly wide glyphs like italic emoji to get clipped
even if they're within the allowed padding.

Fixes xtermjs#4229
@Tyriar Tyriar mentioned this issue Oct 28, 2022
Merged
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addon/canvas area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix clipping of italic emoji Tyriar/xterm.js
1 participant
@Tyriar