Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Once 4 texture atlas pages are filled, queue idle tasks to merge them into a single larger texture #4243

Closed
Tyriar opened this issue Oct 30, 2022 · 0 comments · Fixed by #4252
Closed

Once 4 texture atlas pages are filled, queue idle tasks to merge them into a single larger texture #4243

Tyriar opened this issue Oct 30, 2022 · 0 comments · Fixed by #4252
Assignees
@Tyriar
Labels
area/performance type/enhancement Features or improvements to existing features
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 30, 2022

Based on a WIP branch for #4061

Once combined, we can freeze the atlas page so we only pay the cost of uploading a larger texture once.
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/performance labels Oct 30, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 30, 2022
@Tyriar
Increase texture size as it nears the maximum texture unit
c9ef4a8 
xtermjs#4243 would be a better, but more complicated, solution to this
@Tyriar Tyriar mentioned this issue Oct 30, 2022
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 3, 2022
@Tyriar
Basic merging working
54ee698 
Part of xtermjs#4243
@Tyriar Tyriar mentioned this issue Nov 3, 2022
Merged
@Tyriar Tyriar self-assigned this Nov 3, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/performance type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Continually merge texture atlas pages Tyriar/xterm.js
1 participant
@Tyriar