Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitches caused by large number of color combinations #4484

Open
willmcgugan opened this issue Apr 19, 2023 · 3 comments
Open

Glitches caused by large number of color combinations #4484

willmcgugan opened this issue Apr 19, 2023 · 3 comments
Labels
type/bug Something is misbehaving

Comments

@willmcgugan
Copy link

xterm will blank out parts of the terminal when writing a large amount of color escape sequences.

To reproduce, download this file:

colors.txt

cat the contents in VSCode. You should see a spectrum of colors like the following:

Screenshot 2023-04-19 at 14 57 07

But if you hit a key, you should see that much of the content disappears. Resizing the window often makes it come back.

Occasionally this also results in the following glitch.

Screenshot 2023-04-19 at 14 55 13

I suspect this is the root cause of #4480

Details

  • Browser and browser version:
  • OS version: macOS 13.3.1 (22E261)
  • xterm.js version: VSCode Version: 1.77.3
@jerch
Copy link
Member

jerch commented Apr 28, 2023

@willmcgugan Cannot repro this one in the xterm.js demo under linux/chrome/firefox with any renderer (always get the full "image"), still the other issue #4480 repros here as well (in chrome/firefox with canvas/webgl renderer).

Are there additional steps to do in between to get into the broken output? (Tried several things, like ls and mc output, before getting back to the colors file.)

@Tyriar Tyriar added the type/bug Something is misbehaving label May 2, 2023
@willmcgugan
Copy link
Author

Sorry for the delay. I can't reproduce it on the latest VSCode now. But I can create a glitch that looks very similar.

If I run this command a few times, it will often end up with corrupted textures.

python -m rich.palette

It seems stress related. But if I repeat the above command, I get the following:

Screen.Recording.2023-07-15.at.18.11.28.mov

Oddly, typing reset actually restores the terminal to a usable state.

@jerch
Copy link
Member

jerch commented Jul 31, 2023

@willmcgugan I think thats related to #4534 - the atlas get corrupted at higher pressure (and yeah reset would also clean the atlas).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

3 participants