Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cursorStyleInactive option #4566

Closed
Tyriar opened this issue Jun 16, 2023 · 3 comments · Fixed by #4657
Closed

Add cursorStyleInactive option #4566

Tyriar opened this issue Jun 16, 2023 · 3 comments · Fixed by #4657
Assignees
Labels
help wanted type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 16, 2023

Follow up to #4443

Since we reverted how it used to be (which I still think is the right default), some embedders/users may want it the old way still. We can solve this for everyone by adding a cursorInactiveStyle as suggested by @boettges in #4443 (comment). The name cursorInactiveStyle aligns with selectionInactiveBackground

To implement this you would need to:

  1. Add the new option to xterm.d.ts, options service, etc.
  2. Implement it for dom, canvas and webgl renderers
@Tyriar Tyriar added type/enhancement Features or improvements to existing features help wanted labels Jun 16, 2023
@tisilent
Copy link
Contributor

try try

@tisilent
Copy link
Contributor

Oh, my! Not implementing selectionInactiveBackground..

@Tyriar
Copy link
Member Author

Tyriar commented Aug 10, 2023

@tisilent no need to touch the selection ones, they are just used as an example to ensure we're following the right naming style:

selectionInactiveBackground and cursorInactiveStyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants