Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cursorInactiveStyle option #4657

Merged
merged 6 commits into from Aug 11, 2023
Merged

Add cursorInactiveStyle option #4657

merged 6 commits into from Aug 11, 2023

Conversation

tisilent
Copy link
Contributor

fix #4566

@tisilent
Copy link
Contributor Author

The identifier declared by cursorInactiveStyle is somewhat different from that of cursorStyle. The displayed effect is consistent.

Tyriar
Tyriar requested changes Aug 10, 2023
View reviewed changes
demo/client.ts Outdated Show resolved Hide resolved
src/browser/renderer/dom/DomRendererRowFactory.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar self-assigned this Aug 11, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 11, 2023
Tyriar
Tyriar approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR 👏 I made a few small changes

@Tyriar Tyriar enabled auto-merge August 11, 2023 20:10
@Tyriar Tyriar disabled auto-merge August 11, 2023 20:14
@Tyriar Tyriar enabled auto-merge August 11, 2023 20:15
@Tyriar Tyriar disabled auto-merge August 11, 2023 20:16
@Tyriar Tyriar merged commit dc390ab into xtermjs:master Aug 11, 2023
6 of 8 checks passed
@tisilent tisilent deleted the add-cursorInactiveStyle-option branch August 12, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

Add cursorStyleInactive option
2 participants
@tisilent @Tyriar