Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MutableDisposable and use for CursorBlinkStateManager #4685

Closed
Tyriar opened this issue Aug 18, 2023 · 0 comments · Fixed by #4689
Closed

Add MutableDisposable and use for CursorBlinkStateManager #4685

Tyriar opened this issue Aug 18, 2023 · 0 comments · Fixed by #4689
Assignees
Labels
type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2023

This fixed a memory leak: #4659

But the registration here isn't the best as if blinking is toggled off and on again there will be 2 values registered, despite only the last one being active. VS Code has a nice pattern for this with MutableDisposable: https://github.com/microsoft/vscode/blob/f0f36dff5efa066df997197e1d3a78e2727b70a9/src/vs/base/common/lifecycle.ts#L320-L376

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Aug 18, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 18, 2023
@Tyriar Tyriar self-assigned this Aug 18, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 18, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant