We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fixed a memory leak: #4659
But the registration here isn't the best as if blinking is toggled off and on again there will be 2 values registered, despite only the last one being active. VS Code has a nice pattern for this with MutableDisposable: https://github.com/microsoft/vscode/blob/f0f36dff5efa066df997197e1d3a78e2727b70a9/src/vs/base/common/lifecycle.ts#L320-L376
MutableDisposable
The text was updated successfully, but these errors were encountered:
Add MutableDisposable
a84351a
Part of xtermjs#4685
Track CursorBlinkStateManager in MutableDisposable
d03b5c9
Fixes xtermjs#4685
Tyriar
Successfully merging a pull request may close this issue.
This fixed a memory leak: #4659
But the registration here isn't the best as if blinking is toggled off and on again there will be 2 values registered, despite only the last one being active. VS Code has a nice pattern for this with
MutableDisposable
: https://github.com/microsoft/vscode/blob/f0f36dff5efa066df997197e1d3a78e2727b70a9/src/vs/base/common/lifecycle.ts#L320-L376The text was updated successfully, but these errors were encountered: