Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference CursorStyle in core from webgl #4686

Closed
Tyriar opened this issue Aug 18, 2023 · 0 comments · Fixed by #4688
Closed

Reference CursorStyle in core from webgl #4686

Tyriar opened this issue Aug 18, 2023 · 0 comments · Fixed by #4688
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
5.3.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 18, 2023

This could be derived from core types:

xterm.js/addons/xterm-addon-webgl/src/Types.d.ts

Line 24 in 7b87447

export type CursorStyle = 'outline' | 'block' | 'bar' | 'underline' | 'none';

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Aug 18, 2023
@Tyriar Tyriar added this to the 5.3.0 milestone Aug 18, 2023
@Tyriar Tyriar self-assigned this Aug 18, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 18, 2023
@Tyriar
Simplify cursor style types in webgl
25a78c7 
Fixes xtermjs#4686
@Tyriar Tyriar mentioned this issue Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

Simplify cursor style types in webgl Tyriar/xterm.js
1 participant
@Tyriar