Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image addon packaging not working #4761

Closed
jerch opened this issue Sep 8, 2023 · 1 comment · Fixed by #4862
Closed

image addon packaging not working #4761

jerch opened this issue Sep 8, 2023 · 1 comment · Fixed by #4862
Assignees
@Tyriar
Labels
type/automation Relating to CI/CD pipeline, automation, etc. type/debt Technical debt that could slow us down in the long run
Milestone
5.4.0

Comments

@jerch
Copy link
Member

jerch commented Sep 8, 2023

See #4756.
@jerch jerch added type/debt Technical debt that could slow us down in the long run type/automation Relating to CI/CD pipeline, automation, etc. labels Sep 8, 2023
@jerch jerch mentioned this issue Sep 8, 2023
Merged
@Tyriar
Copy link
Member

Tyriar commented Sep 8, 2023 •
edited

A way for you to test this in CI is to change this line to publish.js --dry-run:

xterm.js/.github/workflows/release.yml

Line 30 in ebd27de

run: node ./bin/publish.js

And trigger it in PR by adding this:

  pull_request:
    branches: [ "master" ]

Here:

xterm.js/.github/workflows/release.yml

Line 7 in ebd27de

branches: [ "master" ]

@Tyriar Tyriar added this to the 5.4.0 milestone Nov 1, 2023
@Tyriar Tyriar self-assigned this Nov 1, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 1, 2023
@Tyriar
Fix image addon build
1c522e1 
Fixes xtermjs#4761
Fixes xtermjs#4802
@Tyriar Tyriar mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/automation Relating to CI/CD pipeline, automation, etc. type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
5.4.0
Development

Successfully merging a pull request may close this issue.

Fix image addon build Tyriar/xterm.js
2 participants
@Tyriar @jerch