Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize addon coordinates are backwards internally #4876

Closed
Tyriar opened this issue Nov 9, 2023 · 0 comments · Fixed by #4877
Closed

Serialize addon coordinates are backwards internally #4876

Tyriar opened this issue Nov 9, 2023 · 0 comments · Fixed by #4877
Assignees
Labels
area/addon/serialize type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 9, 2023

This is the wrong way around:

return handler.serialize({
start: { x: selection.start.y, y: selection.start.x },
end: { x: selection.end.y, y: selection.end.x }
});

const startRow = range.start.x;
const endRow = range.end.x;
const startColumn = range.start.y;
const endColumn = range.end.y;

I don't think this is an API facing bug, just confusing code.

@Tyriar Tyriar added type/bug Something is misbehaving area/addon/serialize labels Nov 9, 2023
@Tyriar Tyriar self-assigned this Nov 9, 2023
@Tyriar Tyriar added this to the 5.4.0 milestone Nov 9, 2023
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/serialize type/bug Something is misbehaving
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant