Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_smoothScroll seems to occur more than once per frame #5036

Closed
Tyriar opened this issue Apr 20, 2024 · 0 comments · Fixed by #5037
Closed

_smoothScroll seems to occur more than once per frame #5036

Tyriar opened this issue Apr 20, 2024 · 0 comments · Fixed by #5037
Assignees
@Tyriar
Labels
area/performance type/bug Something is misbehaving
Milestone
6.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 20, 2024

Repro:

Enable smooth scroll
Add content to terminal
Scroll

Most/all of these animation frames are _smoothScroll firing due to https://github.com/Tyriar/xterm.js/blob/8458bb4c4f4b8b3cf1d4a7207e0d47b13d17260c/src/browser/Viewport.ts#L214

image
@Tyriar Tyriar added type/bug Something is misbehaving area/performance labels Apr 20, 2024
@Tyriar Tyriar added this to the 5.6.0 milestone Apr 20, 2024
@Tyriar Tyriar self-assigned this Apr 20, 2024
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 20, 2024
@Tyriar
Prevent smooth scroll from running more than once per frame
16db227 
Fixes xtermjs#5036
@Tyriar Tyriar mentioned this issue Apr 20, 2024
Merged
@Tyriar Tyriar modified the milestones: 5.6.0, 6.0.0 Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/performance type/bug Something is misbehaving
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Prevent smooth scroll from running more than once per frame Tyriar/xterm.js
1 participant
@Tyriar