Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation performance on Chrome is terrible we should prefer setInterval for cursorBlink #625

Closed
Tyriar opened this issue Apr 3, 2017 · 0 comments
Closed

Animation performance on Chrome is terrible we should prefer setInterval for cursorBlink #625

Tyriar opened this issue Apr 3, 2017 · 0 comments
Assignees
@Tyriar
Labels
type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 3, 2017

See microsoft/vscode#22900

Verified it's a problem for xterm.js by looking at the Chrome task manager, idle CPU jumps from 1% with no blinking to 5-13% with blinking.
@Tyriar Tyriar added the type/bug Something is misbehaving label Apr 3, 2017
@Tyriar Tyriar self-assigned this Apr 3, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 3, 2017
@Tyriar
Use setInterval over animation for cursor blink
aca81c7 
Fixes xtermjs#625
@Tyriar Tyriar mentioned this issue Apr 3, 2017
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 3, 2017
@Tyriar
Use setInterval over animation for cursor blink
eedf07b 
Fixes xtermjs#625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar