Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection is only possible on the text in the current viewport #69

Closed
Tyriar opened this issue Jun 2, 2016 · 4 comments
Closed

Selection is only possible on the text in the current viewport #69

Tyriar opened this issue Jun 2, 2016 · 4 comments
Assignees
Labels
type/bug Something is misbehaving
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2016

While potentially difficult, it's probably possible to do a smooth selection over multiple pages by:

  • Recording start selection position
  • Scroll the terminal up when dragging from terminal and cursor is close to/beyond top
  • Scroll the terminal down when dragging from terminal and cursor is close to/beyond bottom
  • Whenever the terminal is scrolled, reset the selection position
  • When copy is triggered, intercept and select the text between the start and end (probably won't work in older browsers)
@parisk parisk added the type/bug Something is misbehaving label Jun 3, 2016
@parisk
Copy link
Contributor

parisk commented Jun 3, 2016

I think that this will be handled across with all other scrolling issues. The best thing to do IMO is bring scrolling as close as possible to native terminals found in modern OSs (e.g. Ubuntu Terminal and Terminal.app).

@Tyriar
Copy link
Member Author

Tyriar commented Jul 15, 2016

hterm handles this really well but only has the currently displayed viewport in the DOM. We should see how they implement it.

@parisk
Copy link
Contributor

parisk commented Jul 20, 2016

We could mimic the way https://github.com/codemirror/codemirror does it. This could also help with #77.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 9, 2017

Fixed in #670

@Tyriar Tyriar closed this as completed Jun 9, 2017
@Tyriar Tyriar added this to the 2.8.0 milestone Jun 9, 2017
@Tyriar Tyriar self-assigned this Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants