Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support screen readers #731

Closed
Tyriar opened this issue Jun 27, 2017 · 5 comments
Closed

Support screen readers #731

Tyriar opened this issue Jun 27, 2017 · 5 comments
Assignees
@Tyriar
Labels
type/enhancement Features or improvements to existing features
Milestone
3.2.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2017

See microsoft/vscode#8339
@Tyriar Tyriar added the feature label Jun 27, 2017
@Tyriar Tyriar self-assigned this Jun 27, 2017
@Tyriar Tyriar added this to the 2.9.0 milestone Jun 27, 2017
@jluk
Copy link
Contributor

jluk commented Jul 11, 2017

+1 to this! Is this on track for the August release?

@Tyriar
Copy link
Member Author

Tyriar commented Jul 11, 2017

@jluk yep, haven't started yet though so not 100% on how long it will take.

@Tyriar Tyriar mentioned this issue Jul 12, 2017
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jul 12, 2017 •
edited
Loading

Reading the letter back when it's deleted from the prompt does not seem trivial as the prompt line gets re-written when typing:

�[?25l
C:\Users\daimms\Documents\dev\Tyriar\xterm.js>l�[0K
�[48G�[?25h
�[?25l
C:\Users\daimms\Documents\dev\Tyriar\xterm.js>ls�[0K
�[49G�[?25h
�[?25l
C:\Users\daimms\Documents\dev\Tyriar\xterm.js>l�[0K
�[48G�[?25h

This was referenced Jul 13, 2017
Closed
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jul 14, 2017

The following work in NVDA:

  • Hovering a line to read it out
  • Typing reading out the letter that was added

The following does not work:

  • Backspace reading out the letter that was deleted
  • Moving left/right in the prompt reading the letter on the cursor
  • Running a command reading the output (nothing happens)

@Tyriar Tyriar mentioned this issue Jul 20, 2017
Closed
@parisk parisk mentioned this issue Aug 3, 2017
Closed
13 tasks
@Tyriar Tyriar removed this from the 2.9.0 milestone Aug 3, 2017
@Tyriar Tyriar mentioned this issue Aug 3, 2017
Closed
@Tyriar Tyriar mentioned this issue Nov 1, 2017
Closed
@Tyriar Tyriar added this to the 3.1.0 milestone Dec 19, 2017
@Tyriar Tyriar mentioned this issue Jan 3, 2018
Merged
@Tyriar Tyriar modified the milestones: 3.1.0, 3.2.0 Jan 28, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Mar 5, 2018 •
edited
Loading

Fixed in #1182

@Tyriar Tyriar closed this as completed Mar 5, 2018
@Tyriar Tyriar added type/enhancement Features or improvements to existing features and removed type/feature labels Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
2 participants
@Tyriar @jluk