Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The scrollback option should define the number of rows in the buffer above the viewport #847

Closed
Tyriar opened this issue Aug 6, 2017 · 0 comments
Closed

The scrollback option should define the number of rows in the buffer above the viewport #847

Tyriar opened this issue Aug 6, 2017 · 0 comments
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 6, 2017

Right now buffersize = scrollback when really it should be buffersize = rows + scrollback. This is how other terminals seems to act, it will also make supporting #802 easier and allow scrollback to equal 0 without needing to warn like we currently do.

Because of the way that the circular list is structured, resizing rows should resize the buffer to rows + scrollback.
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Aug 6, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 6, 2017
@Tyriar
Make buffer length = rows + scrollback
109d467 
Fixes xtermjs#847
@Tyriar Tyriar self-assigned this Aug 6, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 6, 2017
@Tyriar Tyriar mentioned this issue Aug 7, 2017
Merged
@Tyriar Tyriar closed this as completed Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@Tyriar