Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load BellSound using TS dynamic imports #894

Closed
Tyriar opened this issue Aug 17, 2017 · 4 comments
Closed

Lazy load BellSound using TS dynamic imports #894

Tyriar opened this issue Aug 17, 2017 · 4 comments
Labels
area/performance type/enhancement Features or improvements to existing features

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 17, 2017

After #878 BellSound will be loaded in before the Terminal is initialized, delaying the time it takes and increasing the memory even when no bell is desired.

See microsoft/TypeScript#12364

@mofux
Copy link
Contributor

mofux commented Aug 17, 2017

If lazy import is not an option, couldn't we load it similar to the way we load addons currently?

@Tyriar
Copy link
Member Author

Tyriar commented Aug 17, 2017

The addon loading logic is so messy imo, hopefully we can get away without doing something like that.

@mofux
Copy link
Contributor

mofux commented Aug 17, 2017

Yeah... I think the problem is that there are all these different loaders we have to support. Would be nice to have an abstraction for those, so we could simply import resources lazily. Mmmmpf... that's the part of modern javascript that really sucks - I hope this problem will be solved once the official html module api has settled. Anyway, I don't really see a way of loading the bell audio lazily without it. Even if we get the dynamic imports to work it will depend on the loader (e.g. webpack) to support it.

@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/performance and removed type/bug Something is misbehaving labels Jun 3, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Oct 7, 2019

Using dynamic imports in a library is a bit of a mess, I don't think we should do this. The current situation is decent.

@Tyriar Tyriar closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants