Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Rename scrollDisp to scrollLines #902

Closed
Tyriar opened this issue Aug 19, 2017 · 0 comments
Closed

Proposal: Rename scrollDisp to scrollLines #902

Tyriar opened this issue Aug 19, 2017 · 0 comments
Labels
breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2017

This would match the current more informative naming scheme.
@Tyriar Tyriar added breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding labels Aug 19, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 19, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Nov 4, 2017
@Tyriar
scrollDisp -> scrollLines
05cbe41 
Fixes xtermjs#902
@Tyriar Tyriar mentioned this issue Nov 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@Tyriar