Enforce option value via types

[bmf-ribeiro]

Closes #889

If I missed some property, or if I should do something else, feel free to say something! 😄

[Tyriar]

The proposed change actually makes it worse I think as the typescript server will then present "BellStyle" as the type instead of showing all the strings which is more useful.

I think what I was getting at for #889 was to add more specific setOption calls, which is how the string values are already:

setOption(key: 'fontWeight' | 'fontWeightBold', value: null | 'normal' | 'bold' | '100' | '200' | '300' | '400' | '500' | '600' | '700' | '800' | '900'): void;

[bmf-ribeiro]

Yes, that makes complete sense.

Then, the proper fix was to remove the overloads with type any, as well as adding the missing call, correct?

[Tyriar]

@nikonso the fix happened a while ago, back when there was only a single setOption for 'string' value types.

[bmf-ribeiro]

Yes but doesn't this pull request still make sense nevertheless as is?

Because of the setOption overload with the type any the typings-test.ts could miss some cases, and it was by removing it that I found that the set option overload for rows and cols was missing..

Otherwise, feel free to close it 😉

[Tyriar]

Oh I missed your new commit, the rows/cols thing is definitely good 👍

I think I tried to remove getOption(key: string): any before but then I couldn't call it with generic string object as it was too strict. For example, I think we want to allow this:

const someString: string = 'foo';
term.getOption(someString)

When I tried a while ago this did not work, which would be a bad dev experience if you need to cast it to <'rows'>someString.

[Tyriar]

Thanks again @nikonso! 😃