Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind classList function before calling in toggleFullScreen #1851

Merged
merged 2 commits into from
Dec 20, 2018
Merged

bind classList function before calling in toggleFullScreen #1851

merged 2 commits into from
Dec 20, 2018

Conversation

robins1212
Copy link
Contributor 

fn = term.element.classList.add;
fn('fullscreen');

Can result in a "Illegal invocation" error in Chrome and an "Invalid calling object" error in Edge.
Adding fn = fn.bind(term.element.classList) fixes this.

Tyriar
Tyriar approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robins1212 👌

@Tyriar Tyriar added this to the 3.10.0 milestone Dec 20, 2018
@Tyriar Tyriar merged commit fcef4d5 into xtermjs:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robins1212 @Tyriar