Fix for Windows key printing "Meta" on Linux (and Windows?) #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancampa
added a commit
to juancampa/hyper
that referenced
this pull request
Jan 6, 2019
chabou
pushed a commit
to vercel/hyper
that referenced
this pull request
Jan 6, 2019
|
Already have a fix out which covers all cases: #1881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Linux, press the "Windows" key: The text "Meta" is sent to the terminal. Introduced in #1849
Solution
Do not set
result.keyto "Meta" inevaluateKeyboardEventTests
only tested on Hyper