Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove path mapping to self modules #2169

Merged
merged 1 commit into from Jun 1, 2019
Merged

Remove path mapping to self modules #2169

merged 1 commit into from Jun 1, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 1, 2019

This would cause imports in the common module to reference out/ instead
of src/, this leads to weird behavior when errors are introduced.

@Tyriar
Remove path mapping to self modules
9068107 
This would cause imports in the common module to reference out/ instead
of src/, this leads to weird behavior when errors are introduced.
@Tyriar Tyriar added this to the 4.0.0 milestone Jun 1, 2019
@Tyriar Tyriar self-assigned this Jun 1, 2019
@Tyriar Tyriar merged commit 919c53a into xtermjs:master Jun 1, 2019
@Tyriar Tyriar deleted the dont_path_map_self branch June 1, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Tyriar