Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce options service, move options handling code into common #2171

Merged
merged 6 commits into from
Jun 1, 2019
Merged

Introduce options service, move options handling code into common #2171

merged 6 commits into from
Jun 1, 2019

Commits on Jun 1, 2019

  1. Remove path mapping to self modules 

    This would cause imports in the common module to reference out/ instead
of src/, this leads to weird behavior when errors are introduced.
    @Tyriar
    Tyriar committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    343d4c3 View commit details
    Browse the repository at this point in the history

  2. Introduce options service

    @Tyriar
    Tyriar committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    3ba7069 View commit details
    Browse the repository at this point in the history

  3. Move RenderCoordinator options listener out of Terminal

    @Tyriar
    Tyriar committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    041bd7a View commit details
    Browse the repository at this point in the history

  4. Clean up

    @Tyriar
    Tyriar committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    8a3c60d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into options_service

    @Tyriar
    Tyriar committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    fb022ee View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into options_service

    @Tyriar
    Tyriar committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    ba758ad View commit details
    Browse the repository at this point in the history