Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CharWidth into common and move API tests into ./test #2203

Merged
merged 8 commits into from Jun 8, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 8, 2019

Part of #1507

@Tyriar Tyriar added this to the 4.0.0 milestone Jun 8, 2019
@Tyriar Tyriar self-assigned this Jun 8, 2019
@Tyriar Tyriar changed the title Move CharWidth into common Move CharWidth into common and move API tests into ./test Jun 8, 2019
@jerch
Copy link
Member

jerch commented Jun 8, 2019

@Tyriar Should we move the upcoming benchmark tests also in a separate folder?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 8, 2019

@jerch yes I think they should live in this same folder, this is the problem I mentioned in one of the comments over there.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 8, 2019

@jerch benchmark.json could also live in test/

@Tyriar Tyriar merged commit 2eb77cc into xtermjs:master Jun 8, 2019
@Tyriar Tyriar deleted the char_width branch June 8, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants