Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colon notation for the parser #2241

Merged
merged 30 commits into from
Jul 6, 2019
Merged

colon notation for the parser #2241

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
383849b
Params type implementation
jerch Jun 17, 2019
24c39f6
remove unused import
jerch Jun 17, 2019
cec1aa3
interfaces, add test for clone
jerch Jun 17, 2019
c5385a6
add ":" to param transitions, fix parse loop and tests
jerch Jun 17, 2019
1dd63a6
apply type over codebase
jerch Jun 17, 2019
62007c3
comment storable amount of params in parser
jerch Jun 17, 2019
c558d48
apply colon handling to SGR
jerch Jun 18, 2019
6f047aa
SGR tests, fix bug in 38:5 handling
jerch Jun 18, 2019
069e510
remove as number[] type conversions from tests
jerch Jun 18, 2019
f984204
parser tests
jerch Jun 18, 2019
fc778c7
add usage example for action handler
jerch Jun 18, 2019
c80ff1e
cleanup interface
jerch Jun 18, 2019
8ce67cb
add COLORTERM to env in demo
jerch Jun 18, 2019
63a4e8f
Merge branch 'master' into parser_colon_notation
jerch Jun 25, 2019
b4ae5e1
Merge branch 'master' into parser_colon_notation
Tyriar Jun 29, 2019
5827b4b
change to int32_t
jerch Jul 2, 2019
7dd5dfa
make params mandatory
jerch Jul 2, 2019
a1acd4b
Merge branch 'master' into parser_colon_notation
jerch Jul 2, 2019
357faa7
value range restrictions: clamp max, reject < -1
jerch Jul 2, 2019
f276150
remove IParams from public API
jerch Jul 2, 2019
65b757b
fix typos in docs
jerch Jul 2, 2019
17ca958
js array integration test for addCsiHandler
jerch Jul 2, 2019
69dcabb
Merge branch 'master' into parser_colon_notation
Tyriar Jul 3, 2019
6bcd8e3
ParamsArray to Types.ts
jerch Jul 4, 2019
75d41ab
re-enable commented out tests
jerch Jul 4, 2019
009b3c6
simply error parsing state
jerch Jul 4, 2019
7bd0325
remove example snippet from docs
jerch Jul 4, 2019
6a691f2
fix parser docs
jerch Jul 4, 2019
5f8d07a
cleanup Types.ts, docs for ZDM
jerch Jul 4, 2019
be62267
Merge branch 'master' into parser_colon_notation
jerch Jul 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions demo/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,16 @@ function startServer() {
});

app.post('/terminals', function (req, res) {
const env = Object.assign({}, process.env);
env['COLORTERM'] = 'truecolor';
Tyriar marked this conversation as resolved.
Show resolved Hide resolved
var cols = parseInt(req.query.cols),
rows = parseInt(req.query.rows),
term = pty.spawn(process.platform === 'win32' ? 'cmd.exe' : 'bash', [], {
name: 'xterm-256color',
cols: cols || 80,
rows: rows || 24,
cwd: process.env.PWD,
env: process.env,
cwd: env.PWD,
env: env,
encoding: USE_BINARY_UTF8 ? null : 'utf8'
});

Expand Down
205 changes: 178 additions & 27 deletions src/InputHandler.test.ts
View file
Open in desktop

Large diffs are not rendered by default.