Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blankLine localized string #2284

Merged
merged 1 commit into from
Jul 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/AccessibilityManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,11 @@ export class AccessibilityManager extends Disposable {
const posInSet = (buffer.ydisp + i + 1).toString();
const element = this._rowElements[i];
if (element) {
element.textContent = lineData.length === 0 ? Strings.blankLine : lineData;
if (lineData.length === 0) {
element.innerHTML = ' ';
} else {
element.textContent = lineData;
}
element.setAttribute('aria-posinset', posInSet);
element.setAttribute('aria-setsize', setSize);
}
Expand Down
1 change: 0 additions & 1 deletion src/browser/LocalizableStrings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
* @license MIT
*/

export let blankLine = 'Blank line';
export let promptLabel = 'Terminal input';
export let tooMuchOutput = 'Too much output to announce, navigate to rows manually to read';
5 changes: 0 additions & 5 deletions typings/xterm.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,6 @@ declare module 'xterm' {
* The set of localizable strings.
*/
export interface ILocalizableStrings {
/**
* Announcement for a blank line when `screenReaderMode` is enabled.
*/
blankLine: string;

/**
* The aria label for the underlying input textarea for the terminal.
*/
Expand Down