New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix edge cases in inputhandler methods #2288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerch
changed the title
fix edgecases in inputhandler methods
fix edge cases in inputhandler methods
Jul 4, 2019
…nto cleanup_sequences_files
Gonna stop on this PR as it is already quite big. Remaining issues:
Up for review. |
Tyriar
requested changes
Jul 9, 2019
Tyriar
requested changes
Jul 10, 2019
Tyriar
approved these changes
Jul 11, 2019
This was referenced Jul 13, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses edge case handling for
InputHandler
methods. Currently many methods are still slightly off compared to xterm's behavior.This PR shall enable passing most of the escape sequence files. Shall also fix #1434 and fix #2020. Shall give xterm.js much better results in
vttest
.Things to rework:
Other than stated in cursor at wrong column position behind last cell #1434 I hope to get away with fixing cursor position issues on individual methods. Basic cursor positioning is done now with range checks. Closes Probably incorrect horizontal cursor positioning with certain CSI sequences #2020.
all tab sequence files are failing)All except CBT working.
all tests failing)We are slightly off in the margin handling for
print
,lineFeed
andTerminal.scroll
. Changes to those are more involved and better done with isolated PRs.