Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IBufferService for buffer access in InputHandler #2304

Merged
merged 9 commits into from
Jul 13, 2019
Merged

Use IBufferService for buffer access in InputHandler #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dd239b9
Use IBufferService for buffer access in InputHandler
Tyriar Jul 13, 2019
49fa86d
Get rows/cols in input hander from buffer service
Tyriar Jul 13, 2019
af9c050
Remove ITerminal usage in DECRQSS
Tyriar Jul 13, 2019
94199ae
Introduce logLevel option
Tyriar Jul 13, 2019
2977a53
Use log service everywhere, fix log printing
Tyriar Jul 13, 2019
cd01d8a
Lint
Tyriar Jul 13, 2019
f314543
Log bad linkifier instead of throwing
Tyriar Jul 13, 2019
0c03835
Remove debug internal option completely and add option APIs
Tyriar Jul 13, 2019
4600259
Prefix all logging with 'xterm.js'
Tyriar Jul 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/xterm-addon-webgl/src/WebglUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function createProgram(gl: WebGLRenderingContext, vertexSource: string, f
return program;
}

console.log(gl.getProgramInfoLog(program));
console.error(gl.getProgramInfoLog(program));
Tyriar marked this conversation as resolved.
Show resolved Hide resolved
gl.deleteProgram(program);
}

Expand All @@ -37,7 +37,7 @@ export function createShader(gl: WebGLRenderingContext, type: number, source: st
return shader;
}

console.log(gl.getShaderInfoLog(shader));
console.error(gl.getShaderInfoLog(shader));
gl.deleteShader(shader);
}

Expand Down
2 changes: 1 addition & 1 deletion demo/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ function initOptions(term: TerminalType): void {
// Internal only options
'cancelEvents',
'convertEol',
'debug',
'handler',
'screenKeys',
'termName',
Expand All @@ -235,6 +234,7 @@ function initOptions(term: TerminalType): void {
fontFamily: null,
fontWeight: ['normal', 'bold', '100', '200', '300', '400', '500', '600', '700', '800', '900'],
fontWeightBold: ['normal', 'bold', '100', '200', '300', '400', '500', '600', '700', '800', '900'],
logLevel: ['debug', 'info', 'warn', 'error', 'off'],
Tyriar marked this conversation as resolved.
Show resolved Hide resolved
rendererType: ['dom', 'canvas'],
wordSeparator: null
};
Expand Down
316 changes: 161 additions & 155 deletions src/InputHandler.test.ts
View file
Open in desktop

Large diffs are not rendered by default.