Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes default search addon behavior #2340

Merged
merged 6 commits into from Jul 25, 2019

Conversation

lramos15
Copy link
Contributor

Changes the default search addon behavior to match what other terminals do. Closes #2339. There are currently no Search Addon test cases but it appears to work in my simple tests.

@Tyriar Tyriar added this to the 4.0.0 milestone Jul 24, 2019
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue, searching "package.json" in this (ll, ls):

-rw-rw-r--   1 daniel daniel    719 Jul 10 11:54 .npmignore
-rw-rw-r--   1 daniel daniel     18 Feb 20 10:10 .npmrc
-rw-rw-r--   1 daniel daniel   2001 Jul 16 14:32 package.json
-rw-rw-r--   1 daniel daniel     38 Feb 20 10:10 Procfile
-rw-rw-r--   1 daniel daniel  14338 Jul 23 12:52 README.md
-rw-rw-r--   1 daniel daniel    402 Jul 10 11:54 tsconfig.all.json
-rw-rw-r--   1 daniel daniel   2676 Jul 16 14:32 tslint.json
-rw-rw-r--   1 daniel daniel   1072 Jul 10 11:54 webpack.config.js
-rw-rw-r--   1 daniel daniel 211264 Jul 16 14:32 yarn.lock
ls
~/dev/Tyriar/xterm.js @pr/lramos15/2340 +5/-8
❯ ls
addons    node_modules  typings              Dockerfile     README.md
bin       out           azure-pipelines.yml  LICENSE        tsconfig.all.json
css       out-test      CODE_OF_CONDUCT.md   logo-full.png  tslint.json
demo      src           CONTRIBUTING.md      package.json   webpack.config.js
fixtures  test          docker-compose.yml   Procfile       yarn.lock

~/dev/Tyriar/xterm.js @pr/lramos15/2340 +5/-8

Will find pack in webpack, but when the second a is pressed it will skip the package.json on the same line.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work 👌

@Tyriar Tyriar merged commit 9715bdc into xtermjs:master Jul 25, 2019
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaks API and requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Addon should align with other terminals
2 participants