New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dispose idempotent #2353

Merged

Tyriar merged 1 commit into xtermjs:master from Tyriar:multiple_dispose

Jul 31, 2019

Member

Tyriar commented Jul 31, 2019

Fixes #2351

Issue was caused because vscode calls Terminal.dispose multiple times now due to strict null checks, xterm.js should be more resilient.


          Make dispose idempotent

efaa78f

Fixes xtermjs#2351

Tyriar added this to the 4.0.0 milestone

Tyriar self-assigned this

Tyriar merged commit d20068c into xtermjs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment