Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move buffer tests to Terminal.test.ts and re-enable #2376

Merged
merged 1 commit into from Aug 11, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 10, 2019

Fixes #2361

@Tyriar Tyriar added this to the 4.0.0 milestone Aug 10, 2019
@Tyriar Tyriar self-assigned this Aug 10, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Aug 10, 2019

Only actual change to a test was to use terminal.optionsService over optionsService

@Tyriar Tyriar merged commit 63af42b into xtermjs:master Aug 11, 2019
@Tyriar Tyriar deleted the 2361 branch August 11, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some buffer tests are commented out
1 participant