New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document VT features in docstrings #2386
Conversation
Created a stub wiki page with the output: https://github.com/xtermjs/xterm.js/wiki/VT-features |
@Tyriar I think the feature descriptions are better moved to the function declarations instead of the registering step. This would save some duplicated descriptions. Have to update the "parser" for this (currently does not support multiple |
Writing
|
@Tyriar The basic stuff is done. Not sure yet where the automatic build script should end up. As far as I see, the API doc updates are scripted in xtermjs.org repo, imho it would work likewise for the vtfeatures. Once this has landed, a build script in the website repo could do something like this: git clone https://github.com/xtermjs/xterm.js.git
cd xterm.js
yarn
yarn run --silent vtfeatures > target_file_in_website_repo.md Then just build the created markdown file along with others in the website project. Up for review. |
Created a follow up xtermjs/xtermjs.org#118 |
PR to document VT features inline in docstrings.
@Tyriar Was not able to get this working with typedoc, it does not work with our repo/project structure (throws tons of errors). Thus I parse the comments myself in
bin/extract_vtfeatures.js
.Currently it respects the following notations:
You can either run the command with
node bin/extract_vtfeatures.js src/**/*.ts
or asyarn run --silent vtfeatures
which outputs a markdown document with tables of the features.Next steps:
InputHandler