Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all rows are refreshed on input #3332

Merged
merged 3 commits into from May 11, 2021
Merged

Make sure all rows are refreshed on input #3332

merged 3 commits into from May 11, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 11, 2021

Fixes #3323

@Tyriar Tyriar added this to the 4.12.0 milestone May 11, 2021
@Tyriar Tyriar self-assigned this May 11, 2021
@Tyriar
Copy link
Member Author

Tyriar commented May 11, 2021

I think the scroll event recursion is now handled by the scroll source, the event ignoring seems to be just causing issues now.

@Tyriar Tyriar enabled auto-merge May 11, 2021 12:16
Tyriar and others added 2 commits May 11, 2021 06:48
@Tyriar
Revert "Make sure all rows are refreshed on input"
da39129 
This reverts commit 973eb7b.
@Tyriar
Trigger scroll when ignoring event
bcbcc71 
This is a less aggressive fix that doesn't regress tests
@Tyriar Tyriar merged commit 33f0105 into xtermjs:master May 11, 2021
@Tyriar Tyriar deleted the scroll_refresh branch May 11, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

DOM renderer doesn't refresh screen on input
1 participant
@Tyriar