Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend TLD matching to 14 chars #3596

Merged
merged 2 commits into from Jan 5, 2022
Merged

Extend TLD matching to 14 chars #3596

merged 2 commits into from Jan 5, 2022

Commits on Jan 5, 2022

  1. Extend TLD matching to 14 chars 

    I ran into this issue with hyper wasn't highlighting my `.localhost` domains, which is a legitimate TLD and used by caddy server to allow SSL certs locally.

Then I went down the rabbit hole of TLDs and found currently the longest TLDs are 14 chars which include .BANANAREPUBLIC, .COOKINGCHANNEL, .KERRYLOGISTICS, .WEATHERCHANNEL

I'm not regex expert, but I *think* this should work? 馃榾
    @wesbos
    wesbos committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    6f666f5 View commit details
    Browse the repository at this point in the history

  2. Update WebLinksAddon.ts

    @wesbos
    wesbos committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    84548d5 View commit details
    Browse the repository at this point in the history