Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share animation frame with renderService #3796

Merged
merged 13 commits into from May 17, 2022
Merged

share animation frame with renderService #3796

merged 13 commits into from May 17, 2022

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge commented May 12, 2022 •
edited

fixes #3795

@meganrogge meganrogge self-assigned this May 12, 2022
@meganrogge meganrogge added this to the 4.19.0 milestone May 12, 2022
Tyriar
Tyriar requested changes May 13, 2022
View reviewed changes
src/browser/Types.d.ts Outdated Show resolved Hide resolved
src/browser/RenderDebouncer.ts Outdated Show resolved Hide resolved
Tyriar
Tyriar requested changes May 13, 2022
View reviewed changes
src/browser/RenderDebouncer.ts Outdated Show resolved Hide resolved
@meganrogge
Copy link
Member Author

meganrogge commented May 16, 2022 •
edited

tests are passing when I run them locally.

@meganrogge meganrogge merged commit de5df69 into xtermjs:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
4.19.0
Development

Successfully merging this pull request may close these issues.

decorationService and renderService should share an animation frame
2 participants
@meganrogge @Tyriar