Deflake registerLinkProvider tests #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause of this flakiness problem was related to the click event handler. For some reason it would not go off on some links but it would when clicking elsewhere in the terminal. I tried a bunch of things to keep the click handler to no avail, instead opting to move to using mousedown and mouseup events for activating links which comes with the nice benefit of ensuring that the link on mouseup is the same one on mousedown. Fixes xtermjs#3821
meganrogge
reviewed
May 19, 2022
meganrogge
reviewed
May 19, 2022
meganrogge
approved these changes
May 19, 2022
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this flakiness problem was related to the click event
handler. For some reason it would not go off on some links but it would
when clicking elsewhere in the terminal. I tried a bunch of things to
keep the click handler to no avail, instead opting to move to using
mousedown and mouseup events for activating links which comes with the
nice benefit of ensuring that the link on mouseup is the same one on
mousedown.
Fixes #3821