Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bell settings and sound service in favor of Terminal.onBell #3941

Merged
merged 3 commits into from Jul 27, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 27, 2022

Fixes #3316

@Tyriar Tyriar added this to the 5.0.0 milestone Jul 27, 2022
@Tyriar Tyriar self-assigned this Jul 27, 2022
@Tyriar Tyriar closed this Jul 27, 2022
@Tyriar Tyriar reopened this Jul 27, 2022
@Tyriar Tyriar merged commit fafa7ef into xtermjs:v5 Jul 27, 2022
@Tyriar Tyriar deleted the v5_bell branch July 27, 2022 13:29
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaks API and requires a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant