Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC hyperlink support #4005

Merged
merged 12 commits into from Aug 30, 2022
Merged

OSC hyperlink support #4005

merged 12 commits into from Aug 30, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 7, 2022

Previous attempts: #2904, #3904

Fixes #1134

This sets up the model side of multiple range support but does not implement it, there's an example in the demo test button that should work when it's done:

Screen Shot 2022-08-07 at 11 50 47 am

@Tyriar Tyriar self-assigned this Aug 7, 2022
@Tyriar Tyriar marked this pull request as ready for review August 7, 2022 18:37
@Tyriar Tyriar added this to the 5.0.0 milestone Aug 7, 2022
@Tyriar Tyriar modified the milestones: 5.0.0, 5.1.0 Aug 8, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Aug 8, 2022

This is basically done, I'm going to wait until next month to push it though considering the amount of changes that are already in this month.

@ssbarnea
Copy link

@Tyriar I know lots of people looking forward to get hyperlink support enabled in xterm. Lost of vscode users will be thrilled to see this in sooner.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 30, 2022

@ssbarnea should land in 1.72 🙂

@Tyriar Tyriar merged commit 0c864cd into xtermjs:master Aug 30, 2022
@Tyriar Tyriar modified the milestones: 5.1.0, 5.0.0 Aug 30, 2022
@Tyriar Tyriar deleted the 1134_3 branch August 30, 2022 13:03
@jerch
Copy link
Member

jerch commented Aug 30, 2022

@Tyriar Oh well abit late to the party - do you think this should get a review? Sorry the PR kinda went unnoticed to me...

@Tyriar
Copy link
Member Author

Tyriar commented Aug 30, 2022

@jerch sure a review is always welcome! Can always react to feedback retroactively. I'm trying to integrate it with VS Code atm which is what #4087 is about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hyperlink ansi escapes
4 participants