Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only draw character outline if it has a descent #4074

Merged
merged 2 commits into from Aug 26, 2022
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 26, 2022

Fixes #4059

Before:

image

After:

image

@Tyriar Tyriar added this to the 5.0.0 milestone Aug 26, 2022
@Tyriar Tyriar self-assigned this Aug 26, 2022
@Tyriar Tyriar merged commit 2526409 into xtermjs:master Aug 26, 2022
@Tyriar Tyriar deleted the 4059 branch August 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underline is not continuous
1 participant