Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGR-pixels mouse report #4093

Merged
merged 4 commits into from Sep 1, 2022
Merged

SGR-pixels mouse report #4093

merged 4 commits into from Sep 1, 2022

Conversation

jerch
Copy link
Member

@jerch jerch commented Aug 31, 2022 •
edited

Closes #4092.

TODO:

  • fix cell to pixel offsets translation
  • fix bounding box offsets (seems chrome reports mouse events slightly off the real box?) silly one: system actually draws pointer arrow slightly off
  • API mouse tests
  • vt feature docs

@jerch
Copy link
Member Author

jerch commented Sep 1, 2022 •
edited

@Tyriar Cant get mouse.wheel working with playwright, although it is supported since 1.15. Thus I disabled all wheel related tests and re-enabled all other mouse tests.

@jerch jerch marked this pull request as ready for review September 1, 2022 12:03
Tyriar
Tyriar requested changes Sep 1, 2022
View reviewed changes
src/browser/Terminal.ts Show resolved Hide resolved
test/api/MouseTracking.api.ts Show resolved Hide resolved
@jerch jerch merged commit f9db65c into xtermjs:master Sep 1, 2022
@Tyriar Tyriar added this to the 5.0.0 milestone Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

SGR-pixels mouse reports support
2 participants
@jerch @Tyriar