Do char atlas warmup via new IdleTaskQueue #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Sep 26, 2022
- Optimize critical I/O path for input latency xtermjs/xterm.js#4145 - Add PriorityTaskQueue xtermjs/xterm.js#4144 - Use the browser's IdleDeadline to determine max task time xtermjs/xterm.js#4143 - Defer paused renderer resize to idle callback xtermjs/xterm.js#4142 - Do char atlas warmup via new IdleTaskQueue xtermjs/xterm.js#4141 - Share rgba vars throughout Color.ts, fast setTheme parseColor xtermjs/xterm.js#4140 - Optimize contexts for reading frequently xtermjs/xterm.js#4137 - Fix width of upper 1/8 block char xtermjs/xterm.js#4134 Fixes #161323
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
- Optimize critical I/O path for input latency xtermjs/xterm.js#4145 - Add PriorityTaskQueue xtermjs/xterm.js#4144 - Use the browser's IdleDeadline to determine max task time xtermjs/xterm.js#4143 - Defer paused renderer resize to idle callback xtermjs/xterm.js#4142 - Do char atlas warmup via new IdleTaskQueue xtermjs/xterm.js#4141 - Share rgba vars throughout Color.ts, fast setTheme parseColor xtermjs/xterm.js#4140 - Optimize contexts for reading frequently xtermjs/xterm.js#4137 - Fix width of upper 1/8 block char xtermjs/xterm.js#4134 Fixes microsoft#161323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (done all at once, block main thread):
After (done over ~250ms with minimal frame drops):
The experience is the same, you see the atlas fill in over that short time but it's all warmed up before the initial shell data comes in anyway.