Fix demo again #4193
Merged
Fix demo again #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Oct 9, 2022
Comment on lines
28
to
30
| this.register(toDisposable(() => { | ||
| core.onWillOpen(() => this.activate(terminal)); | ||
| })); |
There was a problem hiding this comment.
This change may not be needed? Regardless this won't work as it will only attach the onWillOpen event after the webgl renderer is disposed. The intent with that is to allow loading webgl/canvas without calling Terminal.open yet
There was a problem hiding this comment.
I think I understand it. So, I've added a try-catch around terminal.open, but it fails somewhere else then. It looks like the terminal remains broken when it needs to fallback to a different renderer such as canvas or dom.
There was a problem hiding this comment.
I see the dom renderer back now, but the demo fails to see that the webgl didn't load, since the error is handled silently in terminal.ts now. It should be thrown again at the end of the terminal initialization.
Tyriar
approved these changes
Oct 9, 2022
Comment on lines
+518
to
+521
| try { | ||
| this._onWillOpen.fire(this.element); | ||
| } | ||
| catch { /* fails to load addon for some reason */ } |
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195 - Improve dotted line for canvas xtermjs/xterm.js#4100 - Fix demo again xtermjs/xterm.js#4193 - Switch to Ubuntu 20.04 xtermjs/xterm.js#4192 - Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180 - Create theme service xtermjs/xterm.js#4188 - Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189 - Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187 - Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Tyriar
added a commit
to microsoft/vscode
that referenced
this pull request
Oct 10, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195 - Fix demo again xtermjs/xterm.js#4193 - Switch to Ubuntu 20.04 xtermjs/xterm.js#4192 - Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180 - Create theme service xtermjs/xterm.js#4188 - Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189 - Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187 - Fix a bunch of memory retention problems xtermjs/xterm.js#4185
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
- Create onSpecificOptionChange and onMultipleOptionChange helpers xtermjs/xterm.js#4195 - Fix demo again xtermjs/xterm.js#4193 - Switch to Ubuntu 20.04 xtermjs/xterm.js#4192 - Fix clearTextureAtlas call as implemented on IRenderer xtermjs/xterm.js#4180 - Create theme service xtermjs/xterm.js#4188 - Ensure stale bitmap is not used when drawing new characters xtermjs/xterm.js#4189 - Lint rule for on=event emitter and rename all methods with on prefix to handle xtermjs/xterm.js#4187 - Fix a bunch of memory retention problems xtermjs/xterm.js#4185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3983.