Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize in demo #4233

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Fix resize in demo #4233

merged 1 commit into from
Oct 27, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Oct 27, 2022

A double resize could happen due to the mismatch in canvas vs device pixel widths

Fixes #4113

A double resize could happen due to the mismatch in canvas vs device
pixel widths

Fixes xtermjs#4113
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 27, 2022
@Tyriar Tyriar self-assigned this Oct 27, 2022
@Tyriar Tyriar enabled auto-merge October 27, 2022 20:56
@Tyriar Tyriar merged commit 4edfc12 into xtermjs:master Oct 27, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Oct 27, 2022

This didn't actually fix the problem entirely

@Tyriar Tyriar deleted the 4113_resize branch October 27, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revamp resize logic in demo
1 participant