fix demo in epiphany #4291
Merged
fix demo in epiphany #4291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that browser have fingerprint detection prevention? There's issue in Brave because of this where it blocks access to various canvas font APIs without actually telling the web app. |
Tyriar
requested changes
Dec 6, 2022
Tyriar
requested changes
Dec 7, 2022
Tyriar
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4223. (also prolly for older safari/webkit in general)
Note that beside the addon loading logic, there was also an issue in the canvas renderer - for some reason some glyphs have no width/height, which older safari/webkit does not like. Not sure if that needs further investigation/fix on why glyphs might be empty.