Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Buffer.ts #4335

Merged
merged 1 commit into from Dec 20, 2022
Merged

Cleanup Buffer.ts #4335

merged 1 commit into from Dec 20, 2022

Conversation

jerch
Copy link
Member

@jerch jerch commented Dec 19, 2022

Fixes #4331.

@Tyriar Tyriar added this to the 5.2.0 milestone Dec 20, 2022
Tyriar
Tyriar approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like deleted code 🎉

@Tyriar Tyriar merged commit 3142460 into xtermjs:master Dec 20, 2022
@jerch
Copy link
Member Author

jerch commented Dec 20, 2022

I like deleted code 🎉

rm -rf / is your friend 🙈
(Seriously - happened to me once in the past on a remote server connection, and I think the keyboard got bite marks from that incident. So yeah backups are a pretty decent thing, if you have one 🤣)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Remove Buffer.iterator
2 participants
@jerch @Tyriar