Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure line is defined via clamp #4403

Merged
merged 5 commits into from Feb 7, 2023
Merged

ensure line is defined via clamp #4403

merged 5 commits into from Feb 7, 2023

Conversation

meganrogge
Copy link
Member

@meganrogge meganrogge self-assigned this Feb 7, 2023
@meganrogge meganrogge added this to the 5.2.0 milestone Feb 7, 2023
@meganrogge meganrogge changed the title check if line is defined ensure line is defined via clamp Feb 7, 2023
@meganrogge meganrogge enabled auto-merge (squash) February 7, 2023 20:54
Tyriar
Tyriar approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If we ever see this again after this is merged then something is really wrong as lines.get() should always return something between ydisp and ydisp + rows - 1

@meganrogge meganrogge merged commit 8a1faed into xtermjs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read properties of undefined (reading 'loadCell')
2 participants
@meganrogge @Tyriar