Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-render browser DOM style onOptionsChanged, fixes xtermjs#4474 #4475

Merged
merged 3 commits into from
May 9, 2023
Merged

Re-render browser DOM style onOptionsChanged, fixes xtermjs#4474 #4475

merged 3 commits into from
May 9, 2023

Conversation

kelvinhammond
Copy link
Contributor

Fixes #4474

@Tyriar
Copy link
Member

Tyriar commented May 7, 2023

Thanks @kelvinhammond, looks good, I just moved the inject call into _handleOptionsChanged.

@Tyriar Tyriar added this to the 5.2.0 milestone May 7, 2023
@Tyriar Tyriar merged commit 075f330 into xtermjs:master May 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Font size is not updated when changed in browser DOM rendering
2 participants
@kelvinhammond @Tyriar