image addon fixes

[jerch]

TODO:

• remaining changes from 0.4.3 (defer canvas creation & cleanup lifecycling)
• adjust README
• fix flakey tests

Fixes #4620, fixes #4627.

[jerch]

@Tyriar The last commit adds the image addon to the publish script. I am not sure if this will work out of the box or if this will create account access issues on npm.

[Tyriar]

@jerch looks like it did fail, I'm locked out of my npm account currently but it might just be a matter of you giving collaborator access to either my account or an xterm.js one if we set that up

[jerch]

I can add you, if I find out how to do that 😮

Gimme 5 minutes to mess around with npm account stuff...

[jerch]

Sent you an invitation. Not sure what you have to do to complete it though...

[Tyriar]

Got the invitation, can't use it until I can login though (it said 1-3 days)

[jerch]

Eww, is that a security concept? Let ppl wait long enough to shake off the bad guys? 🤣

[Tyriar]

@jerch my 2FA recovery codes aren't working, so I think it needs a manual check

[jerch]

Just checked the package settings again on npm - looks like you have maintainer state now. So maybe it just works now?

[Tyriar]

@jerch yep got into the account. I re-ran the job and it succeeded 🎉 https://dev.azure.com/xtermjs/xterm.js/_build/results?buildId=6493&view=logs&j=15c39577-a302-5fb0-b018-53da76770408&t=510866e4-c5fa-511e-f61e-bee9c6d19f98

I see it also re-published a slightly older build for xterm, but that'll be sorted out on next merge.