Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circle line custom powerline glyph. #4729

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

tisilent
Copy link
Contributor

fix #4071

@Tyriar
Copy link
Member

Tyriar commented Aug 25, 2023

State in PR:

Screenshot 2023-08-25 at 6 46 51 AM Screenshot 2023-08-25 at 6 47 36 AM

@tisilent do you know what's happening with the middle where it seems to go inwards a little?

image

@tisilent
Copy link
Contributor Author

tisilent commented Aug 25, 2023

I need to shift the top and bottom slightly outward. I'm adjusting it. I've been looking at this picture for a long time and my eyes are a bit blurry. 👀

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2023

Looks good, thanks for looking into this. I shifted them 20% inwards so they're centered:

Screenshot 2023-08-28 at 2 20 49 AM

@Tyriar Tyriar added this to the 5.3.0 milestone Aug 28, 2023
@Tyriar Tyriar self-assigned this Aug 28, 2023
@Tyriar Tyriar enabled auto-merge August 28, 2023 09:22
@Tyriar Tyriar merged commit 2dd4dfd into xtermjs:master Aug 28, 2023
13 of 15 checks passed
@tisilent
Copy link
Contributor Author

Hi @Tyriar, What tool are you using to zoom in on pixels.

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2023

@tisilent that's my image editor for vscode "Luna paint"

@tisilent tisilent deleted the circle-line-custom-powerline-glyph branch September 11, 2023 16:02
@tisilent
Copy link
Contributor Author

@Tyriar "Luna paint" very very very nice~~~~
1694448171865

@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2023

@tisilent ❤️ thanks, it has a lot of hours in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The circle line custom powerline glyph is the wrong shape
2 participants